Limit the allocated size of the sample indice table by the file size. #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zaggy1024
force-pushed
the
limit-sample-table-size
branch
from
20c6571 to
f1742b7
Compare
Zaggy1024
force-pushed
the
limit-sample-table-size
branch
from
f1742b7 to
f69e178
Compare
|
If this issue is able to occur on the MP4 side, this currently doesn't affect that, since the MP4 code in Gecko seems more complicated to do this with. If I can figure out how to get the size of the downloaded data there, I can probably modify it to request indices as the available data increases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof of concept for my solution to slow OOMs in
create_sample_table()laid out in #395.